Skip to content

🐛 E2E: Propagate clusterctl variables for cluster upgrades #12949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2025
Merged

🐛 E2E: Propagate clusterctl variables for cluster upgrades #12949

merged 2 commits into from
Nov 12, 2025
+5 −0

Conversation

@vknabel
Copy link
Contributor

@vknabel vknabel commented Nov 4, 2025

What this PR does / why we need it:
We'd like to implement E2E tests for our infrastructure provider. In this case using ClusterUpgradeConformanceSpec.

Though in our case the Control Plane IP address is being created from within our testing suite in Go code and therefore cannot be passed to the tests using the E2EConfig or environment variables. Instead we load the config and patch the variables in-memory. Then we call ClusterUpgradeConformanceSpec. Though the clusterctl.ApplyClusterTemplateAndWait currently does not respect these variables and always derives them from the config file itself.

Passing the variables to the clusterctl apply would solve this issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Nov 4, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 4, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from elmiko November 4, 2025 12:18
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari November 4, 2025 12:18
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 4, 2025

Hi @vknabel. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025

@vknabel Thx! Please take a look at #12949 (comment)

@vknabel
Copy link
Contributor Author

vknabel commented Nov 7, 2025 •
edited
Loading

@sbueringer thx for having a look.
The CLA agreement is in internal progress at my company. It should be signed on monday.

@sbueringer
Copy link
Member

sbueringer commented Nov 7, 2025

/ok-to-test
/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 7, 2025
sbueringer
sbueringer reviewed Nov 11, 2025
View reviewed changes
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 12, 2025
@sbueringer
Copy link
Member

sbueringer commented Nov 12, 2025

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 12, 2025

LGTM label has been added.

Git tree hash: 76f9c3c6f812e1eb0e5c4d51e2889ea6e8ac5025

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6658a26 into kubernetes-sigs:main Nov 12, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@elmiko elmiko Awaiting requested review from elmiko

@sivchari sivchari Awaiting requested review from sivchari

Assignees

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

v1.12

Development

Successfully merging this pull request may close these issues.

3 participants

@vknabel @k8s-ci-robot @sbueringer